[FE] 페어룸 타이머 기능 구현 #114
Merged
[FE] 페어룸 타이머 기능 구현 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
greetings1012
approved these changes
Jul 25, 2024
|
|
||
| useEffect(() => { | ||
| if (isActive && timeLeft > 0) { | ||
| timerRef.current = setInterval(() => { |
There was a problem hiding this comment.
setInterval로 타이머 시간을 계산하면 큰 오차가 발생할 수도 있어요.
이번 스프린트가 끝난 후, Date를 이용해 현재 시간을 계산하는 로직으로 다시 구현해봐도 좋을 것 같아요! 😁
관련 블로그
| border: 0.8rem solid transparent; | ||
| border-radius: 50%; | ||
| background-image: linear-gradient(white, white), | ||
| conic-gradient( |
There was a problem hiding this comment.
👍
다만 초 단위로 렌더링되다 보니 애니메이션이 부드럽게 작동하지는 않네요 😢
추후 리팩터링 때 밀리초 단위를 적용하면 더 부드럽게 작동할 수 있겠네요!
dle234
reviewed
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
연관된 이슈
구현한 기능
상세 설명
DEFAULT_TIME값을 주어 테스트 진행했습니다.util파일로 분리해야 할지 고민입니다.